Refactor code structure for improved readability and maintainability; removed redundant code blocks and optimized function calls.

account_manage.php

@@ -147,12 +147,7 @@ $view .= '</div>';
 
 $view .= '<div class="tabs">
             <a href="#" class="active">'.$view_account_information.'</a>
-            <a href="#">'.$view_account_contact.'</a>
+         </div>';
-            <a href="#">'.$account_billing.'</a>
-            <a href="#">'.$account_shipping.'</a>
-            <a href="#">'.$tab3.'</a>
-        </div>
-    ';
 //Define Permission & Profile
 
 $view .= '<div class="content-block tab-content active">
@@ -186,8 +181,10 @@ $view .= '<div class="content-block tab-content active">
             </div>
         </div>';
 
-$view .= '<div class="content-block tab-content">
+$view .= '<div class="tabs">
- 
+            <a href="#">'.$view_account_contact.'</a>
+         </div>
+         <div class="content-block tab-content">
             <div class="form responsive-width-100">
                 <label for="">'.$account_contactfirstname.'</label>
                 <input name="accountdetails[contactfirstname]" type="text" value="'.$accountdetails->contactfirstname.'">
@@ -206,8 +203,10 @@ $view .= '<div class="content-block tab-content">
             </div>
 </div>';
 
-$view .= '<div class="content-block tab-content">
+$view .= '<div class="tabs">
- 
+            <a href="#">'.$account_billing.'</a>
+         </div>
+         <div class="content-block tab-content">
             <div class="form responsive-width-100">
                 <label for="">'.$account_billstreetadress.'</label>
                 <input name="accountdetails[billstreetadress]" type="text" value="'.$accountdetails->billstreetadress.'">
@@ -231,7 +230,10 @@ $view .= '<div class="content-block tab-content">
             </div>
         </div>';
 
-$view .= '<div class="content-block tab-content">
+$view .= '<div class="tabs">
+            <a href="#">'.$account_shipping.'</a>
+         </div>
+         <div class="content-block tab-content">
             <div class="form responsive-width-100">
                 <label for="">'.$account_streetadress.'</label>
                 <input name="accountdetails[streetadress]" type="text" value="'.$accountdetails->streetadress.'">
@@ -272,8 +274,10 @@ $view .= '<div class="content-block tab-content">
 $partner_data = json_decode($_SESSION['partnerhierarchy']);
 $soldto_dropdown = listPartner('soldto',$_SESSION['permission'],$accounthierarchy->soldto,'');
 
-$view .= '<div class="content-block tab-content">
+$view .= '<div class="tabs">
-        
+            <a href="#">'.$tab3.'</a>
+         </div>
+         <div class="content-block tab-content">
             <div class="form responsive-width-100">
                 <label for="">'.$general_salesid.'</label>
                 <input name="salesid" type="text" value="'.$partner_data->salesid.'">

assets/admin.js

@@ -23,17 +23,37 @@ document.querySelector('.responsive-toggle').onclick = event => {
 document.querySelectorAll('.tabs a').forEach((element, index) => {
     element.onclick = event => {
         event.preventDefault();
-        document.querySelectorAll('.tabs a').forEach(element => element.classList.remove('active'));
+        
-        document.querySelectorAll('.tab-content').forEach((element2, index2) => {
+        // Toggle the clicked tab
-            if (index == index2) {
+        const isActive = element.classList.contains('active');
-                element.classList.add('active');
+        const tabContent = document.querySelectorAll('.tab-content')[index];
-                element2.style.display = 'block';
+        
-            } else {
+        // Remove active class from all tabs and contents
-                element2.style.display = 'none';
+        document.querySelectorAll('.tabs a').forEach(el => el.classList.remove('active'));
-            }
+        document.querySelectorAll('.tab-content').forEach(content => {
+            content.classList.remove('active');
+            content.style.display = 'none';
         });
+        
+        // If it wasn't active, make it active (collapsible behavior)
+        if (!isActive && tabContent) {
+            element.classList.add('active');
+            tabContent.classList.add('active');
+            tabContent.style.display = 'block';
+        }
     };
 });
+
+// Initialize first tab as open by default
+if (document.querySelectorAll('.tabs a').length > 0) {
+    const firstTab = document.querySelectorAll('.tabs a')[0];
+    const firstContent = document.querySelectorAll('.tab-content')[0];
+    if (firstTab && firstContent) {
+        firstTab.classList.add('active');
+        firstContent.classList.add('active');
+        firstContent.style.display = 'block';
+    }
+}
 if (document.querySelector('.filters a')) {
     let filtersList = document.querySelector('.filters .list');
     let filtersListStyle = window.getComputedStyle(filtersList);

cartest_manage.php

@@ -251,14 +251,20 @@ foreach($arrayQuestions_cartest as $group){
         $view .= '<a href="#">'.$group['Group'].'</a>';
     }
 }
-$view .= '</div>';    
+$view .= '</div>';
-    
+
 foreach($arrayQuestions_cartest as $group){    
   
     if ($group['Group_sequence'] == 1){
+        $view .= '<div class="tabs">
+            <a href="#" class="active">'.$group['Group'].'</a>
+         </div>';
         $view .= '<div class="content-block tab-content active">
                     <div class="form responsive-width-100">';
    } else {
+        $view .= '<div class="tabs">
+            <a href="#">'.$group['Group'].'</a>
+         </div>';
         $view .= '<div class="content-block tab-content">
                     <div class="form responsive-width-100">';
    }

contract_manage.php

@@ -127,11 +127,8 @@ if ($update_allowed === 1){
 $view .= '</div>';
 
 $view .= '<div class="tabs">
-            <a href="#" class="active">'.$tab1 .'</a>
+            <a href="#" class="active">'.$tab1.'</a>
-            <a href="#">'.$tab2.'</a>
+         </div>';
-            <a href="#">'.$tab3.'</a>
-        </div>
-    ';
 
 $view .='<div class="content-block tab-content active">
             <div class="form responsive-width-100">
@@ -257,6 +254,10 @@ $shipto_dropdown = listPartner('shipto',$_SESSION['permission'],$partner_data->s
 $location_dropdown = listPartner('location',$_SESSION['permission'],$partner_data->location,'');
 
 //DISPLAY
+$view .= '<div class="tabs">
+            <a href="#">'.$tab2.'</a>
+         </div>';
+
 $view .= '<div class="content-block tab-content">
             <div class="form responsive-width-100">
 ';
@@ -273,6 +274,10 @@ $view .= '
     </div>
 </div>';
 
+$view .= '<div class="tabs">
+            <a href="#">'.$tab3.'</a>
+         </div>';
+
 $view .= '<div class="content-block tab-content">
         <div class="form responsive-width-100">
             <label for="">'.$general_created.'</label>

dealer_manage.php

@@ -155,13 +155,7 @@ $view .= '</div>';
 
 $view .= '<div class="tabs">
             <a href="#" class="active">'.($view_dealers_information ?? 'Dealer information').'</a>
-            <a href="#">'.($view_dealer_details_1 ?? 'Descriptions').'</a>
+         </div>';
-            <a href="#">'.($view_dealer_details_3 ?? 'Location').'</a>
-            <a href="#">'.($dealers_openinghours ?? 'opening_hours').'</a>
-            <a href="#">'.($view_dealer_details_2 ?? 'Settings').'</a>
-            <a href="#">'.$tab3.'</a>
-         </div>
-    ';
 
 $view .= '<div class="content-block tab-content active">
             <div class="form responsive-width-100">
@@ -190,6 +184,10 @@ $view .= '<div class="content-block tab-content active">
             $view .= '<input type="hidden" name="rowID" value="'.($responses['rowID'] ?? '').'">';
         }
 
+$view .= '<div class="tabs">
+            <a href="#">'.($view_dealers_descriptions ?? 'Description').'</a>
+         </div>';
+
 $view .= '<div class="content-block tab-content">
             <div class="form responsive-width-100">
                 <label for="dealerdescription">'.($dealers_short_description ?? 'short').'</label>
@@ -325,6 +323,10 @@ $view .= '
         </div>
     </div>';
 
+$view .= '<div class="tabs">
+            <a href="#">'.$tab3.'</a>
+         </div>';
+
 $view .= '<div class="content-block tab-content">
         <div class="form responsive-width-100">
             <label for="dealercode">'.$general_created.'</label>

equipment_manage.php

@@ -157,13 +157,6 @@ if ($update_allowed === 1 || $equipment_owner === 1){
    
 $view .= '</div>';
 
-$view .= '<div class="tabs">
-            <a href="#" class="active">'.$tab1.'</a>
-            <a href="#">'.$tab2.'</a>
-            <a href="#">'.$tab3.'</a>
-         </div>
-    ';
-
 //create product option list
 $product_option_list ='';
 foreach ($products as $product){
@@ -188,7 +181,10 @@ if (isset($products_software) && $products_software !=''){
     $product_software_list .= '</select>';
 }
 
-$view .= '<div class="content-block tab-content active">
+$view .= '<div class="tabs">
+            <a href="#" class="active">'.$tab1.'</a>
+         </div>
+         <div class="content-block tab-content active">
             <div class="form responsive-width-100">
                 <label for="status">'.$equipment_label3.'</label>
                 <select id="status" name="status" '.($update_allowed_special==0? 'disabled':'').'>
@@ -232,8 +228,11 @@ $location_dropdown = listPartner('location',$_SESSION['permission'],$partner_dat
 if (isset($partner_data->section)){$section = getPartnerName($partner_data->section) ?? 'Not specified';} else {$section = 'Not specified';}
 
 
-//DISPLAY
+//DISPLAY TAB 2
-$view .= '<div class="content-block tab-content">
+$view .= '<div class="tabs">
+            <a href="#">'.$tab2.'</a>
+         </div>
+         <div class="content-block tab-content">
             <div class="form responsive-width-100">
 ';
 $view .= '<label for="status">'.$general_salesid.'</label>';
@@ -266,24 +265,28 @@ if (is_array($geo_details)) {
     $geodetails_lon = '';
 }
 
-$view .= '<div class="content-block tab-content">
+//DISPLAY TAB 3
-        <div class="form responsive-width-100">
+$view .= '<div class="tabs">
-            <label for="productcode">'.$general_created.'</label>
+            <a href="#">'.$tab3.'</a>
-            <input id="name" type="text" name="" placeholder="'.$general_created.'" value="'.$equipment['created'].'" readonly>
+         </div>
-            <label for="productcode">'.$general_createdby.'</label>
+         <div class="content-block tab-content">
-            <input id="name" type="text" name="" placeholder="'.$general_createdby.'" value="'.$equipment['createdby'].'" readonly>
+            <div class="form responsive-width-100">
-            <label for="productcode">'.$general_updated.'</label>
+                <label for="productcode">'.$general_created.'</label>
-            <input id="name" type="text" name="" placeholder="'.$general_updated.'" value="'.$equipment['updated'].'" readonly>
+                <input id="name" type="text" name="" placeholder="'.$general_created.'" value="'.$equipment['created'].'" readonly>
-            <label for="productcode">'.$general_updatedby.'</label>
+                <label for="productcode">'.$general_createdby.'</label>
-            <input id="name" type="text" name="" placeholder="'.$general_updatedby.'" value="'.$equipment['updatedby'].'" readonly>
+                <input id="name" type="text" name="" placeholder="'.$general_createdby.'" value="'.$equipment['createdby'].'" readonly>
-            <label for="productcode">'.$equipment_label11.'</label>
+                <label for="productcode">'.$general_updated.'</label>
-            <input id="name" type="text" name="order_ref" placeholder="'.$equipment_label11.'" value="'.$equipment['order_ref'].'">
+                <input id="name" type="text" name="" placeholder="'.$general_updated.'" value="'.$equipment['updated'].'" readonly>
-            <label for="productcode">'.$equipment_label12.'</label>
+                <label for="productcode">'.$general_updatedby.'</label>
-            <input id="name" type="text" name="geolocation[]" placeholder="'.$equipment_label12.'" value="'.$geodetails_lat.'">
+                <input id="name" type="text" name="" placeholder="'.$general_updatedby.'" value="'.$equipment['updatedby'].'" readonly>
-            <input id="name" type="text" name="geolocation[]" placeholder="'.$equipment_label12.'" value="'.$geodetails_lon.'">
+                <label for="productcode">'.$equipment_label11.'</label>
-            '.($update_allowed_special==1? $changelog:'').'
+                <input id="name" type="text" name="order_ref" placeholder="'.$equipment_label11.'" value="'.$equipment['order_ref'].'">
-        </div>      
+                <label for="productcode">'.$equipment_label12.'</label>
-    </div>';
+                <input id="name" type="text" name="geolocation[]" placeholder="'.$equipment_label12.'" value="'.$geodetails_lat.'">
+                <input id="name" type="text" name="geolocation[]" placeholder="'.$equipment_label12.'" value="'.$geodetails_lon.'">
+                '.($update_allowed_special==1? $changelog:'').'
+            </div>      
+        </div>';
 
 
 $view .= '</form>';

history_manage.php

@@ -115,9 +115,7 @@ $view .= '</div>';
 
 $view .= '<div class="tabs">
             <a href="#" class="active">'.$tab1.'</a>
-            <a href="#" class="">'.$tab3.'</a>
+         </div>';
-        </div>
-    ';
 
 $view .= '<div class="content-block tab-content active">
             <div class="form responsive-width-100">
@@ -152,6 +150,10 @@ $view .= '<div class="content-block tab-content active">
            </div>
         </div>';
 
+$view .= '<div class="tabs">
+            <a href="#">'.$tab3.'</a>
+         </div>';
+
 $view .= '<div class="content-block tab-content">
         
             <div class="form responsive-width-100">

media_manage.php

@@ -123,9 +123,7 @@ $view .= '</div>';
 
 $view .= '<div class="tabs">
             <a href="#" class="active">'.$tab1 .'</a>
-            <a href="#">'.$tab3.'</a>
+         </div>';
-        </div>
-    ';
 
 //Define Service and User enabled
 $view .= '<div class="content-block tab-content active">
@@ -141,6 +139,10 @@ $view .= '<div class="content-block tab-content active">
 $view .= '</div>
         </div>';
 
+$view .= '<div class="tabs">
+            <a href="#">'.$tab3.'</a>
+         </div>';
+
 $view .= '<div class="content-block tab-content">
         <div class="form responsive-width-100">
             <label for="">'.$general_created.'</label>

pricelists_manage.php

@@ -179,9 +179,7 @@ $view .= '</div>';
 
 $view .= '<div class="tabs">
             <a href="#" class="active">'.$tab1 .'</a>
-            <a href="#">'.$tab3.'</a>
+         </div>';
-        </div>
-    ';
 
 //Define Service and User enabled
 $view .= '<div class="content-block tab-content active">
@@ -215,6 +213,10 @@ $view .= '<div class="content-block tab-content active">
             </div>
         </div>';
 
+$view .= '<div class="tabs">
+            <a href="#">'.$tab3.'</a>
+         </div>';
+
 $view .= '<div class="content-block tab-content">
         <div class="form responsive-width-100">
             <label for="">'.$general_created.'</label>

product_manage.php

@@ -159,10 +159,7 @@ $view .= '</div>';
 
 $view .= '<div class="tabs">
             <a href="#" class="active">'.$tab1.'</a>
-            <a href="#">'.$tab4.'</a>
+         </div>';
-            <a href="#">'.$tab3.'</a>
-         </div>
-    ';
 
 $view .= '<div class="content-block tab-content active">
             <div class="form responsive-width-100">
@@ -218,7 +215,10 @@ $view .= '          </div>
             </div>
         </div>';
 
-$view .= '<div class="content-block tab-content">
+$view .= '<div class="tabs">
+            <a href="#">'.$tab4.'</a>
+         </div>
+         <div class="content-block tab-content">
             <div class="form responsive-width-100">
                 <label for="serialized">'.($product_configurable ?? 'Configurable').'</label>
                 <select id="status" name="configurable">
@@ -248,12 +248,15 @@ $view .= '<div class="content-block tab-content">
             </div>
         </div>';
 
-$view .= '<div class="content-block tab-content">
+$view .= '<div class="tabs">
-        <div class="form responsive-width-100">
+            <a href="#">'.$tab3.'</a>
-            <label for="productcode">'.$general_created.'</label>
+         </div>
-            <input id="name" type="text" name="" placeholder="'.$general_created.'" value="'.$product['created'].'" readonly>
+         <div class="content-block tab-content">
-            <label for="productcode">'.$general_createdby.'</label>
+            <div class="form responsive-width-100">
-            <input id="name" type="text" name="" placeholder="'.$general_createdby.'" value="'.$product['createdby'].'" readonly>
+                <label for="productcode">'.$general_created.'</label>
+                <input id="name" type="text" name="" placeholder="'.$general_created.'" value="'.$product['created'].'" readonly>
+                <label for="productcode">'.$general_createdby.'</label>
+                <input id="name" type="text" name="" placeholder="'.$general_createdby.'" value="'.$product['createdby'].'" readonly>
             <label for="productcode">'.$general_updated.'</label>
             <input id="name" type="text" name="" placeholder="'.$general_updated.'" value="'.$product['updated'].'" readonly>
             <label for="productcode">'.$general_updatedby.'</label>

products_attributes_manage.php

@@ -176,9 +176,7 @@ $view .= '</div>';
 
 $view .= '<div class="tabs">
             <a href="#" class="active">'.$tab1 .'</a>
-            <a href="#">'.$tab3.'</a>
+         </div>';
-        </div>
-    ';
 
 
 $view .='<div class="content-block tab-content active">
@@ -216,6 +214,10 @@ $view .='<div class="content-block tab-content active">
         </div>
         ';
 
+$view .= '<div class="tabs">
+            <a href="#">'.$tab3.'</a>
+         </div>';
+
 $view .= '<div class="content-block tab-content">
         <div class="form responsive-width-100">
             <label for="">'.$general_created.'</label>

rma_manage.php

@@ -337,7 +337,11 @@ if($rma['header']['servicereport_available'] == 0 ){
       $view .='<a href="#">'.($rma_return_tab2 ?? 'Questions').'</a>';
 }
 
-$view .= '</div>';    
+$view .= '</div>';
+
+$view .= '<div class="tabs">
+            <a href="#" class="active">'.$tab1.'</a>
+         </div>';
     
 $view .= '<div class="content-block tab-content active">
             <div class="form responsive-width-100">
@@ -356,6 +360,10 @@ $view .= '<div class="content-block tab-content active">
             </div>
         </div>';
 
+$view .= '<div class="tabs">
+            <a href="#">'.$tab2.'</a>
+         </div>';
+
 $view .= '<div class="content-block tab-content">
             <div class="form responsive-width-100">';
 if($rma['header']['servicereport_available'] == 0 ){